chore(storage): Remove gRPC backwards compatibility shims #15146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pulkit0110
changed the title
product-auto-label
bot
added
the
api: storage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prepare-for-v3.0.0 #15146 +/- ##
======================================================
- Coverage 92.93% 92.93% -0.01%
======================================================
Files 2392 2392
Lines 215083 215022 -61
======================================================
- Hits 199887 199822 -65
- Misses 15196 15200 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since gRPC is now GA, removing the backwards compatibility shims for gRPC.
storage_experimentalnamespace is still present in grpc_plugin.h as it has the members related to gRPC metrics likeEnableGrpcMetricsOptionandGrpcMetricsPeriodOption. I'm not sure whether this is completely implemented.Simplify MakeGrpcClient(): drop the
UseRest()branch and ENV-var fallback so it unconditionally returns a gRPC-backed Client. Previously MakeGrpcClient() could return JSON client by comparing the ENV variable. Now it is removed so that we've a clear separation of gRPC and JSON clients.Refactored unit tests as per the new behavior.
This change is