deprecate(storage): Mark google::cloud::storage::oauth2 as deprecated by shubham-up-47 · Pull Request #15139 · googleapis/google-cloud-cpp · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

deprecate(storage): Mark google::cloud::storage::oauth2 as deprecated #15139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

deprecate(storage): Mark google::cloud::storage::oauth2 as deprecated #15139

wants to merge 9 commits into from

Conversation

shubham-up-47
Copy link
Contributor

@shubham-up-47 shubham-up-47 commented May 13, 2025 •
edited by scotthart
Loading

Marking it deprecated since, the unified credentials documented in @ref guac is recommended now.

This change is Reviewable

@shubham-up-47 shubham-up-47 requested review from a team as code owners May 13, 2025 10:57
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label May 13, 2025
@shubham-up-47 shubham-up-47 changed the title cleanup(storage): Mark google::cloud::storage::oauth2 as deprecated deprecate(storage): Mark google::cloud::storage::oauth2 as deprecated May 13, 2025
@codecov Codecov
Copy link

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.93%. Comparing base (7fe2884) to head (406f3c4).
Report is 36 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15139      +/-   ##
==========================================
- Coverage   92.93%   92.93%   -0.01%     
==========================================
  Files        2392     2392              
  Lines      215105   215105              
==========================================
- Hits       199904   199903       -1     
- Misses      15201    15202       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddelgrosso1
Copy link
Contributor

@scotthart is this something we should point at your 'prepare for 3.x' branch?

scotthart
scotthart requested changes May 13, 2025
View reviewed changes
Copy link
Member

@scotthart scotthart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion

google/cloud/storage/oauth2/anonymous_credentials.h line 40 at r2 (raw file):

 */
class GOOGLE_CLOUD_CPP_DEPRECATED(
    "This class will be removed shortly. "

Everywhere we say removed shortly let's instead say removed in v3.0.0 and later

Code quote:

removed shortly

@shubham-up-47
Copy link
Contributor Author

Reviewable status: 0 of 9 files reviewed, 1 unresolved discussion

google/cloud/storage/oauth2/anonymous_credentials.h line 40 at r2 (raw file):

 */
class GOOGLE_CLOUD_CPP_DEPRECATED(
    "This class will be removed shortly. "

Everywhere we say removed shortly let's instead say removed in v3.0.0 and later

Code quote:

removed shortly

Done.

@shubham-up-47 shubham-up-47 requested a review from scotthart May 15, 2025 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotthart scotthart Awaiting requested review from scotthart

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shubham-up-47 @ddelgrosso1 @scotthart

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.