chore(storage): Remove storage::internal::CommonMetadata and storage::internal::AccessControlCommon
#15138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
shubham-up-47
changed the title
shubham-up-47
changed the title
storage::internal::CommonMetadata and storage::internal::AccessControlCommon
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15138 +/- ##
==========================================
- Coverage 92.93% 92.93% -0.01%
==========================================
Files 2392 2388 -4
Lines 215105 215044 -61
==========================================
- Hits 199904 199847 -57
+ Misses 15201 15197 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shubham-up-47
changed the title
storage::internal::CommonMetadata and storage::internal::AccessControlCommonstorage::internal::CommonMetadata and storage::internal::AccessControlCommon
|
This looks good, but we will need to wait to merge it until we're working on v3 due to the potential breaking changes. |
|
@scotthart do we have a '3.x staging' branch we can point this at? |
ddelgrosso1
added
the
next major: breaking change
|
Repointed this at the |
scotthart
force-pushed
the
prepare-for-v3.0.0
branch
from
45113de to
14dd653
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
storage::internal::CommonMetadataandstorage::internal::AccessControlCommon,fixes #9897
This change is