lint: switch order Ruff's hooks `fix` -> `format` by Borda · Pull Request #1912 · gitpython-developers/GitPython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

lint: switch order Ruff's hooks fix -> format #1912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2024
Merged

lint: switch order Ruff's hooks fix -> format #1912

merged 1 commit into from
May 7, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented May 7, 2024

Since fix may do some additional changes, it makes sense to first run fixing and the formatting so you may need to run pre-commit only once in case fixing wont be compatible with formatting

Byron
Byron approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that sounds very reasonable.
Updating the version of ruff at the same time seems like a win, too.

@Byron Byron merged commit cd490f8 into gitpython-developers:main May 7, 2024
@Borda Borda deleted the lint/ruff branch May 7, 2024 19:28
@Borda
Copy link
Contributor Author

Borda commented May 7, 2024

@Byron, btw, how about installing this bot?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byron Byron Byron approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @Byron

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.