Enable docker builds with shell using different dockerfile #639
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds a new multi-stage Dockerfile to support interactive shell access for developers by building the Go server on Alpine and producing a shell-enabled runtime image.
- Introduces
Dockerfile-with-shellwith a build stage (including Git and Go caching) and a runtime stage with ca-certificates. - Provides default ENTRYPOINT and CMD for running the compiled server.
- Enables developers to build and run the image with
/bin/shfor distro-based debugging.
Comments suppressed due to low confidence (1)
Dockerfile-with-shell:1
- Consider adding updates to the project README (or a docs file) with instructions on how to build and run this new Dockerfile (e.g.,
docker build -f Dockerfile-with-shell . -t <tag>and the recommendeddocker runflags) so developers can discover and use it easily.
FROM golang:1.24.4-alpine AS build
| -o /bin/github-mcp-server cmd/github-mcp-server/main.go | ||
|
|
||
| # Make a stage to run the app | ||
| FROM alpine:3.21 |
There was a problem hiding this comment.
[nitpick] To improve clarity and allow targeted builds, you might name the runtime stage (e.g., FROM alpine:3.21 AS runtime) so consumers can explicitly reference it when building or inspecting images.
Suggested change
| FROM alpine:3.21 | |
| FROM alpine:3.21 AS runtime |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a first step to enabling shell access in our Docker image for developers that wish to use an image with a distro, this adds
Dockerfile-with-shellto the repository root and can be run like so:docker build --file Dockerfile-with-shell . --tag ghcr.io/github/github-mcp-server:sh docker run --rm -it --entrypoint /bin/sh ghcr.io/github/github-mcp-server:shIn future we could consider letting this be a later build stage in our main Dockerfile and for our releases use the specific distroless build stage, while enabling others to build with a distro by default which is more common.
Motivation: #574
Docker's custom override: dgageot@2e73e0a
The Docker MCP Hub listing that points to unsanctioned (by GitHub) fork: https://hub.docker.com/r/mcp/github-mcp-server
CC @dgageot