fix: move defaulted 'state' param after non-default params in list_code_scanning_alerts #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de_scanning_alerts Fixes `SyntaxError: parameter without a default follows parameter with a default` when using github-mcp-server with the Python MCP SDK
ph3t
force-pushed
the
fix-default-param-order
branch
from
da9c97b to
7404ba5
Compare
SamMorrowDrums
approved these changes
Jun 7, 2025
|
Interesting, is this formally part of the spec or a quirk of the Python client SDK? |
@SamMorrowDrums Turns out the issue was in the ADK (nerve) I'm using, so this change didn't fix anything. But basically, Python expects functions with default args to be last. I have opened a new PR as an apology for this useless fix: #494 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
SyntaxError: parameter without a default follows parameter with a defaulterror when using github-mcp-server with the Python MCP SDKCloses: N/A