Make it clear that Docker needs to be running #214
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiedo
requested review from
juruen,
SamMorrowDrums,
williammartin and
toby
as code owners
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to make it clear that Docker must be running for the MCP server to work.
- Updated the Docker prerequisites in the README to clarify that Docker must be running.
- Adjusted the numbering of the prerequisites list accordingly.
juruen
approved these changes
Apr 10, 2025
manian0430
pushed a commit
to ChrisLally/github-mcp-server
that referenced
this pull request
Apr 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems obvious but if you don't use Docker in your daily work, it may be non-obvious that Docker also needs to be "running" for the MCP server to work.