feat: Add list_branches tool to view repository branches by aryasoni98 · Pull Request #151 · github/github-mcp-server · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

feat: Add list_branches tool to view repository branches #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

feat: Add list_branches tool to view repository branches #151

wants to merge 0 commits into from

Conversation

aryasoni98
Copy link
Contributor

Closes: #141

@Copilot Copilot AI review requested due to automatic review settings April 7, 2025 10:59
Copilot
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

juruen
juruen requested changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@juruen juruen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank so much for opening this PR! 🚀

A couple of things if you don't mind:

  • Could you please update the README with the new supported tool
  • Re: pagination, please take a look at #137 which we have just merged and changed a bit how we handle pagination. If you could adopt that way of handling pagination in this PR, it'd be really great.

Thank you!

@aryasoni98
Copy link
Contributor Author

Thank so much for opening this PR! 🚀

A couple of things if you don't mind:

  • Could you please update the README with the new supported tool
  • Re: pagination, please take a look at pkg/github: fix use of per page parameter #137 which we have just merged and changed a bit how we handle pagination. If you could adopt that way of handling pagination in this PR, it'd be really great.

Thank you!

Thank you for the review! I've addressed both points:

  1. Added the list_branches tool documentation to the README under the Repository section, including all parameters and their descriptions.

  2. Updated the pagination handling to use withPagination() helper function instead of direct parameter definitions, matching the approach used in PR pkg/github: fix use of per page parameter #137. The changes include:

    • Removed explicit page and perPage parameter definitions
    • Added withPagination() to the tool definition
    • Updated the handler to use optionalPaginationParams for parameter extraction

All tests are passing and the code is now consistent with the project's pagination handling standards. Let me know if you'd like me to make any additional adjustments!

@aryasoni98 aryasoni98 requested a review from juruen April 7, 2025 21:50
juruen
juruen requested changes Apr 8, 2025
View reviewed changes
Copy link
Collaborator

@juruen juruen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for the back and forth! But would you capitalizing the new tool to be consistent with the main?

Thanks!

@aryasoni98 aryasoni98 mentioned this pull request Apr 9, 2025
Closed
@aryasoni98 aryasoni98 closed this Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@juruen juruen juruen requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to view "branches" for a repo
2 participants
@aryasoni98 @juruen

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.