Diff-informed queries: phase 3 (non-trivial locations) #19957
+837
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -223,6 +223,14 @@ | |||
| state1 = state2 + delta | |||
| ) | |||
| } | |||
|
|
|||
| predicate observeDiffInformedIncrementalMode() { | |||
Check warning
Code scanning / CodeQL
Dead code Warning
| any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 263 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-119/OverrunWriteProductFlow.ql@269:8:269:41), Column 5 does not select a source or sink originating from the flow call on line 263 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-119/OverrunWriteProductFlow.ql@270:58:270:63), Flow call outside 'select' clause (/Users/d10c/src/semmle-code/ql/cpp/ql/src/Security/CWE/CWE-119/OverrunWriteProductFlow.ql@249:5:249:76) | ||
| } | ||
|
|
||
| Location getASelectedSinkLocation(DataFlow::Node sink) { |
Check warning
Code scanning / CodeQL
Dead code Warning
| @@ -59,6 +59,14 @@ | |||
| ) | |||
| ) | |||
| } | |||
|
|
|||
| predicate observeDiffInformedIncrementalMode() { | |||
Check warning
Code scanning / CodeQL
Dead code Warning
| any() // TODO: Make sure that the location overrides match the query's select clause: Column 1 does not select a source or sink originating from the flow call on line 81 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/experimental/Likely Bugs/ArrayAccessProductFlow.ql@83:8:83:22), Column 7 does not select a source or sink originating from the flow call on line 81 (/Users/d10c/src/semmle-code/ql/cpp/ql/src/experimental/Likely Bugs/ArrayAccessProductFlow.ql@84:23:84:27) | ||
| } | ||
|
|
||
| Location getASelectedSinkLocation(DataFlow::Node sink) { |
Check warning
Code scanning / CodeQL
Dead code Warning
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
from
ff3a4b9 to
95fe462
Compare
| @@ -3,6 +3,7 @@ | |||
| private import codeql.actions.dataflow.ExternalFlow | |||
| private import codeql.actions.security.ArtifactPoisoningQuery | |||
| private import codeql.actions.security.UntrustedCheckoutQuery | |||
| private import codeql.actions.security.ControlChecks | |||
Check warning
Code scanning / CodeQL
Redundant import Warning
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
from
95fe462 to
ec649a6
Compare
d10c
force-pushed
the
d10c/diff-informed-phase-3
branch
from
ec649a6 to
aff62c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables diff-informed mode on queries that select a location other than dataflow source or sink.
I start with automatically generated stubs and then handle each TODO item in its own commit.