Java/Ruby/Rust/QL: add overlayChangedFiles relation to dbscheme
#19896
Conversation
nickrolfe
added
the
depends on internal PR
github-actions
bot
added
Java
Ruby
QL-for-QL
Rust
nickrolfe
force-pushed
the
nickrolfe/overlay-deleted-files
branch
2 times, most recently
from
3a6fe71 to
b6d49dc
Compare
nickrolfe
force-pushed
the
nickrolfe/overlay-deleted-files
branch
from
b6d49dc to
2ac7bf8
Compare
nickrolfe
force-pushed
the
nickrolfe/overlay-deleted-files
branch
from
2ac7bf8 to
d8574a6
Compare
| @@ -114,6 +114,10 @@ databaseMetadata( | |||
| string value: string ref | |||
| ); | |||
|
|
|||
| overlayChangedFiles( | |||
| string path: string ref | |||
There was a problem hiding this comment.
Because this will be populated by the CLI from the list of changed files calculated by the CodeQL Action, which in turn uses git to diff against the base branch, and it seems quite possible that there will be paths for files that aren't in the database and therefore don't have a @file entity.
If we wanted to use @file, we'd have to consider making the CLI also emit files tuples to ensure db consistency. It seems simpler just to use strings, at the low cost of adding an extra join in the discard predicates.
Sure. Thankfully, git will complain about conflicts if that happens (it already did once since I opened this PR). |
This PR will be synchronised with a CLI change that emits
overlayChangedFilestuples, which will let us write more robust discard predicates (including discarding tuples from files that have been deleted in the overlay).Also, bump the
overlay_support_versiontag for Ruby, since the updated version will be used to indicate that the dbscheme contains theoverlayChangedFilesrelation.