fix: default to system accent color on invalid user color by codebytere · Pull Request #47660 · electron/electron · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

fix: default to system accent color on invalid user color #47660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: default to system accent color on invalid user color #47660

wants to merge 1 commit into from
+42 −41

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented Jul 3, 2025 •
edited
Loading

Description of Change

Fixes an issue where an invalid color passed as a string to accentColor would result in a white accent color. This happened because our ParseCSSColor utility falls back to white on parse failure. When a user passes an invalid string we should instead fall back to system color.

This fixes that by reworking our ParseCSSColor utility to return an optional value and leaving it up to the callers to decide their fallback color.

cc @bpasero

Checklist

Release Notes

Notes: Fixes an issue where an invalid color passed as a string to accentColor would result in a white accent color.

@codebytere codebytere requested review from ckerr and deepak1556 July 3, 2025 18:36
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch. labels Jul 3, 2025
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr Awaiting requested review from ckerr

@deepak1556 deepak1556 Awaiting requested review from deepak1556

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
new-pr 🌱 PR opened recently semver/patch backwards-compatible bug fixes target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codebytere

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.