feat: add app.isHardwareAccelerationEnabled()
#47614
Open
+23
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebytere
added
semver/minor
codebytere
force-pushed
the
is-hardware-acceleration-enabled
branch
from
bf13304 to
ee82128
Compare
jkleinsc
requested changes
Jun 30, 2025
| } else { | ||
| disable_hw_acceleration_ = true; | ||
| } | ||
| disable_hw_acceleration_ = true; |
There was a problem hiding this comment.
This flag is used elsewhere to determine that disabling hw acceleration has been requested:
| if (content::GpuDataManager::Initialized()) | ||
| return content::GpuDataManager::GetInstance() | ||
| ->HardwareAccelerationEnabled(); | ||
| return !disable_hw_acceleration_; |
There was a problem hiding this comment.
I don't think we should use this flag to determine if hardware acceleration is enabled - unless we change the meaning to mean that it is intended to be disabled in the future.
| @@ -1197,6 +1197,10 @@ Disables hardware acceleration for current app. | |||
|
|
|||
| This method can only be called before app is ready. | |||
|
|
|||
| ### `app.isHardwareAccelerationEnabled()` | |||
|
|
|||
| Returns `boolean` - whether hardware acceleration is currently disabled. | |||
There was a problem hiding this comment.
Similar to getGPUFeatureStatus, it may be worth calling out that this data will only be accurate after gpu-info-update is emitted. I'd also be curious if that'd be true in practice after the initial time its emitted.
Lines 1216 to 1217 in 4f69c58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR adds
app.isHardwareAccelerationEnabled(), which can be used to determine whether hardware acceleration has been disabled either on the machine or viaapp.disableHardwareAcceleration().Checklist
npm testpassesRelease Notes
Notes: Added
app.isHardwareAccelerationEnabled()