fix: crash when closing devtools after focus by codebytere · Pull Request #47435 · electron/electron · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

fix: crash when closing devtools after focus #47435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: crash when closing devtools after focus #47435

wants to merge 3 commits into from

Conversation

codebytere
Copy link
Member

Description of Change

Closes #19985.

Fixes an issue where closing devtools immediately after focus causes a crash. The crash happened because closing DevTools immediately destroys the DevTools WebContents while the main WebContents is still notifying observers for the focus event, which is prohibited.

Checklist

Release Notes

Notes: Fixed an issue where closing devtools immediately after focus caused a crash.

@codebytere codebytere requested review from ckerr and deepak1556 June 10, 2025 15:53
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 10, 2025
@codebytere codebytere added semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. labels Jun 10, 2025
deepak1556
deepak1556 reviewed Jun 10, 2025
View reviewed changes
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 11, 2025
@codebytere codebytere force-pushed the fix-close-crash branch 2 times, most recently from 632736c to 8d2f6e4 Compare June 14, 2025 05:01
@github-actions github-actions bot added the target/38-x-y PR should also be added to the "38-x-y" branch. label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 left review comments

@ckerr ckerr Awaiting requested review from ckerr

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
semver/patch backwards-compatible bug fixes target/35-x-y PR should also be added to the "35-x-y" branch. target/36-x-y PR should also be added to the "36-x-y" branch. target/37-x-y PR should also be added to the "37-x-y" branch. target/38-x-y PR should also be added to the "38-x-y" branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash when closing devtools after focus
2 participants
@codebytere @deepak1556

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.