Fixed #36490 -- Avoided unnecessary transaction in bulk_create. #19614
+60
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shangxiao
approved these changes
Jul 2, 2025
This comment was marked as spam.
This comment was marked as spam.
When dealing with an heterogeneous set of object with regards to primary key assignment that fits in a single batch there's no need to wrap the single INSERT statement in a transaction.
…andling. Whether or not returning_fields should be specified to _insert is not a function of each batches so the conditional can be moved outside of the loop.
Asserting an upper bound for the number of executed queries can be achieved by using CaptureQueriesContext instead of enabling the whole DEBUG machinery.
charettes
changed the title
|
FWIW recent improvements in |
charettes
commented
Jul 2, 2025
| @@ -800,7 +801,11 @@ def bulk_create( | |||
| fields = [f for f in opts.concrete_fields if not f.generated] | |||
| objs = list(objs) | |||
| objs_with_pk, objs_without_pk = self._prepare_for_bulk_create(objs) | |||
There was a problem hiding this comment.
It appears that this whole primary key assignment partition logic can also be elided if we'd like to go further
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36490
Branch description
When bulk_create deals with an heterogeneous set of object with regards to primary key assignment that fits in a single batch there's no need to wrap the resulting single INSERT statement in a transaction.
Checklist
mainbranch.