Fixed #36488 -- use & separator when merging query strings in RedirectView #19610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tView * If a RedirectView(query_string=True) has query params in its destination URL, append incoming request query params with & instead of always using ? * Add tests for this behavior When merging query strings that share a param, the view will append both values (resulting in e.g. pork=spam&pork=ham) instead of replacing one with the other.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
nessita
reviewed
Jun 30, 2025
| @@ -252,7 +252,7 @@ def get_redirect_url(self, *args, **kwargs): | |||
|
|
|||
| args = self.request.META.get("QUERY_STRING", "") | |||
| if args and self.query_string: | |||
| url = "%s?%s" % (url, args) | |||
| url = "%s%s%s" % (url, "&" if "?" in url else "?", args) | |||
There was a problem hiding this comment.
How about:
Suggested change
| url = "%s%s%s" % (url, "&" if "?" in url else "?", args) | |
| if urlparse(url).query: | |
| url = f"{url}&{args}" | |
| else: | |
| url = f"{url}?{args}" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36488
Branch description
When merging query strings that share a param, the view will append both values (resulting in e.g. pork=spam&pork=ham) instead of replacing one with the other.
Checklist
mainbranch.