Fix logger error message with partial callbacks #19609
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
|
Hello @krishna-holvi, the problem seems legitimate but just like any non-trivial bug fixing this will require a ticket as well as tests. See 4a1150b to get an idea for where the tests should be added. It might also be an opportunity to change the |
Many thanks for having a look and thank you for those links. I'll update the PR |
krishna-holvi
force-pushed
the
krishna-fix-logger-partial-error
branch
from
3426f37 to
a8db985
Compare
|
Looks like it caused a few failures See
Try running this particular suite locally |
krishna-holvi
force-pushed
the
krishna-fix-logger-partial-error
branch
8 times, most recently
from
b087dca to
1839277
Compare
|
Updated with simplified approach as discussed in ticket. thank you! |
krishna-holvi
force-pushed
the
krishna-fix-logger-partial-error
branch
from
1839277 to
2f6bc74
Compare
krishna-holvi
force-pushed
the
krishna-fix-logger-partial-error
branch
from
2f6bc74 to
7c6b037
Compare
|
@charettes tests are passing now, can you please have a look |
Trac ticket number
ticket-36487
Branch description
This is a trivial change to fix the logger error message. Fixed the error message for the case on commit callback is a partial which doesn't have the property
__qualname__.Checklist
mainbranch.