@nessita I have followed the approach you suggested, i used the logic from log_response() for escaping part. Does this look good to you? I ran the tests and it worked. Would love to know your opinion over this.

@nessita I have followed the approach you suggested, i used the logic from log_response() for escaping part. Does this look good to you? I ran the tests and it worked. Would love to know your opinion over this.

It looks quite good, thank you!

I was wondering if we could fully reuse log_response since the helper would allow response and other attrs to be None. Did you consider this? Would there be a blocker?

@nessita I have followed the approach you suggested, i used the logic from log_response() for escaping part. Does this look good to you? I ran the tests and it worked. Would love to know your opinion over this.

It looks quite good, thank you!

I was wondering if we could fully reuse log_response since the helper would allow response and other attrs to be None. Did you consider this? Would there be a blocker?

Thank you! and about reusing the log_response(), I did some research and found that we use log_message() before the request passes by anything (directly logged into our dev server, even before hitting the middlewares or views logics), but we use log_response() when we have a proper httpresponse object which is the part after we hit the views logic in the codebase. So reusing log_response() doesnt seem like very viable to me, and our major target being handling the log injection, we use part of log_response() which solves it. (But yeah sure if we could have handled the other attrs to be None, would have been great) So yeah there are some blockers here.

What are your opinions on this @nessita ?

@nessita i just wanted to know more of your opinions on this pr, if there is something i should look into? or the changes are satisfactory?

@YashRaj1506 pls stop pinging people directly, the reviewers have this on their list of things to look at and it's unnecessary to burden them with further notifications 👍

@shangxiao Totally! I get it!