Much simpler range sum operation #1392
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have provided the overview and implementation of a much simpler range sum query function, which does not require splitting the query. I have explicitly outlined the three cases that may arise while processing a range sum query and the code directly reflects these cases. This implementation is much more beginner friendly and intuitive.
|
I tend to write segment trees in a similar way but I'm not sure what @adamant-pwn would think. Should this be a diff section or undo the previous? |
adamant-pwn
reviewed
Mar 24, 2025
|
Thanks for the pull request! I also prefer this implementation. Moreover, I would also use half-open intervals, rather than segments. The main issue here is that all the other places in the article still use the old style. @Stillswarm would you have some time to also update the remaining sections of the article to use this style? |
|
@adamant-pwn sure. i will try to refactor as soon as possible |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have provided the overview and implementation of a much simpler range sum query function, which does not require splitting the original query. I have explicitly outlined the three cases that may arise while processing a range sum query and the code directly reflects these cases. This implementation is much more beginner friendly and intuitive.