feat: add database purge for old provisioner job logs and timings #18744
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blink-so[bot]](https://avatars.githubusercontent.com/in/1271127?s=60&v=4){kind=small}
This commit implements a database purge feature for old provisioner job logs
and timings to help manage database storage:
- Add migration to add purged_at column to workspace_builds table
- Add SQL queries to delete old provisioner job logs and timings:
* Purge all logs/timings from deleted workspaces
* Purge logs/timings from non-deleted workspaces older than 90 days
(except for the latest build)
- Update dbpurge.go to call the new deletion methods
- Add comprehensive tests for the purge behavior
- Fix test setup to properly create deleted workspaces for testing
- Update generated database interfaces and mocks
Tested: All dbpurge tests pass, including the new comprehensive test
for provisioner job log and timing purging.
Co-authored-by: dannykopping <373762+dannykopping@users.noreply.github.com>
- Update migration to recreate workspace_build_with_user view to include purged_at column - Fix formatting issues in test file (spacing and extra blank line) - This resolves the gen and fmt CI failures Co-authored-by: dannykopping <373762+dannykopping@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a database purge feature for old provisioner job logs and timings to help manage database storage growth.
Changes
Database Migration
000347_workspace_builds_purged_atto add apurged_atcolumn to theworkspace_buildstable for tracking purged buildsSQL Queries
DeleteOldProvisionerJobLogsandDeleteOldProvisionerJobTimingsqueries inprovisionerjobs.sqlDatabase Purge Integration
dbpurge.goto call the new deletion methods with a 90-day thresholdTesting
TestDeleteOldProvisionerJobLogsAndTimingsGenerated Code Updates
dbmockto include new methodsdbmetricspackageTesting
The implementation has been thoroughly tested:
Impact
This feature will help reduce database storage usage by automatically cleaning up old provisioner job logs and timings while preserving important recent data and the latest build information for active workspaces.