chore(site): reduce fetch interval on workspaces page #18725
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… pending workspaces
There was a problem hiding this comment.
Pull Request Overview
This PR reduces the polling frequency on the Workspaces page by dynamically adjusting the refetch interval:
- Polls every 5s when any workspace build is in an intermediate state, otherwise every 30s.
- Disables polling on errors and when the tab is inactive.
Comments suppressed due to low confidence (2)
site/src/pages/WorkspacesPage/WorkspacesPage.tsx:80
- [nitpick] Consider adding unit or integration tests to verify that the polling interval switches correctly based on error states and active build presence.
refetchInterval: ({ state }) => {
site/src/pages/WorkspacesPage/WorkspacesPage.tsx:85
- workspace.latest_build may be undefined, causing runtime errors; use optional chaining (e.g.,
workspace.latest_build?.status) or provide a default value to guard against missing builds.
const status = workspace.latest_build.status;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to coder/internal#720
The workspaces query fetches a lot of information. We can probably reduce the frequency at which we fetch data by polling less often if no workspace builds are in 'intermediate' states.