note added to docs for proper responsiveness when relative chart parent is inside grid or flex container by DavidAshburn · Pull Request #11509 · chartjs/Chart.js · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

note added to docs for proper responsiveness when relative chart parent is inside grid or flex container #11509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

note added to docs for proper responsiveness when relative chart parent is inside grid or flex container #11509

wants to merge 1 commit into from

Conversation

DavidAshburn
Copy link

@DavidAshburn DavidAshburn commented Sep 24, 2023 •
edited
Loading

When the relative chart parent element is inside of a flex or grid container you get weird overflows on resize unless the relative chart parent has min-width set to 0

@DavidAshburn
note added to docs for proper responsive sizing when the chart parent…
bbc673d 
… element is a child of a flex or grid container
LeeLenaleee
LeeLenaleee requested changes Sep 24, 2023
View reviewed changes
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile so can't review correctly but main point of critique i see now is all the style changes you did like params in a div on sperate lines or double quotes for strings. This is not in line with the rest of the documentation.

@DavidAshburn DavidAshburn mentioned this pull request Sep 25, 2023
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeLenaleee LeeLenaleee LeeLenaleee requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavidAshburn @LeeLenaleee

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.