[Fix test] "Expiration (exp) time must be a unix time stamp" on 32-bit platform by afilippov1985 · Pull Request #899 · bshaffer/oauth2-server-php · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

[Fix test] "Expiration (exp) time must be a unix time stamp" on 32-bit platform #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Fix test] "Expiration (exp) time must be a unix time stamp" on 32-bit platform #899

wants to merge 2 commits into from

Conversation

afilippov1985
Copy link
Contributor

After this PR #898 I able to run tests. And I get:

There were 2 failures:

1) OAuth2\GrantType\JwtBearerTest::testInvalidJti
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Expiration (exp) time must be a unix time stamp'
+'JSON Token Identifier (jti) has already been used'

D:\eclipseworkspace\oauth2-server-php\test\OAuth2\GrantType\JwtBearerTest.php:291

2) OAuth2\GrantType\JwtBearerTest::testJtiReplayAttack
Failed asserting that null is not null.

Tests failed because ctype_digit($jwt['exp']) evals to false when $jwt['exp'] is double (it becomes double when $jwt['exp'] > PHP_INT_MAX)

// on 32-bit
$d = 99999999900;
var_dump($d, ctype_digit($d));
//double(99999999900) bool(false) 

$d = '99999999900';
var_dump($d, ctype_digit($d));
//string(11) "99999999900" bool(true) 

// on 64-bit
$d = 99999999900;
var_dump($d, ctype_digit($d));
//int(99999999900) bool(true) 

$d = '99999999900';
var_dump($d, ctype_digit($d));
//string(11) "99999999900" bool(true)

To fix this we should always write big integers as strings ('99999999900')
or write integers as integers (12345) and integers must be <= PHP_INT_MAX

@bshaffer
Copy link
Owner

bshaffer commented Jul 3, 2019

Thanks, I did not really test this library for 32 bit. My deepest regrets that you are dealing with such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afilippov1985 @bshaffer

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.