-
Notifications
You must be signed in to change notification settings - Fork 279
Added Vagrantfile for easy launching #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow nice work!!!
Thanks! |
…ory where the lib resides
A Dockerfile would also be a nice touch |
Also, it would be good to link to Vagrant installation in the README for users who want to try Vagrant but do not have it set up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got the error General error: 14 unable to open database file when running the Authorization code, refresh, and implicit flows, and the error Failed to connect to localhost port 8081 when running the User Credentials flow. I also received the oauth error Invalid or missing response type when running OpenID's ID Token flow.
README.md
Outdated
@@ -10,6 +10,37 @@ If this is your first time here, try [experimenting with the live demo](http://b | |||
Installation | |||
------------ | |||
|
|||
## With Vagrant | |||
|
|||
$ vagrant up |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include installation instructions and instructions on what to do after this command, i.e. Now browse to http://localhost:8080 to see the OAuth2 Demo Application
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, yes. My bad. Will fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I'm having none of these errors. Can you give me some instructions on how to recreate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't even see where in the code you're connecting to 8081.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Figured it out. Now I'm getting the connection error. Fixing ...
I could do that, but there are several issues with Docker that really boil down to: Docker is meant for production environments. The idea is to have as little running on one container as possible; separating the web server from the DB. Even setting up SSH is a PITA, whereas for Vagrant you just type |
No, I totally agree about linking to vagrant's documentation. Currently there is no link. Also, I believe further setup is required, as I was receiving errors. So really, just do a few things to flesh out the vagrant instructions:
|
README.md
Outdated
@@ -10,6 +10,41 @@ If this is your first time here, try [experimenting with the live demo](http://b | |||
Installation | |||
------------ | |||
|
|||
We have provided a Vagrantfile for easy installation. Vagrant is software that controls some of the major virtualization software such as [VMWare Workstation](https://www.vmware.com/products/workstation.html) and [Oracle VirtualBox](https://www.virtualbox.org/). With a simple text file, you can clone a machine to run locally on your computer. More details can be found at https://www.vagrantup.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These instructions should be moved under ## With Vagrant
, as they are specific to that section. Also, the vagrant hyperlink at the end should be actually linked, i.e. [https://www.vagrantup.com](https://www.vagrantup.com)
Is that after the changes I posted about an hour ago? |
Can you try checking out my latest changes and then run |
|
||
a2enmod rewrite | ||
echo "xdebug.remote_enable=on" >> /etc/php/5.6/apache2/conf.d/xdebug.ini | ||
echo "xdebug.remote_host=192.168.34.1" >> /etc/php/5.6/apache2/conf.d/xdebug.ini |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This address seems oddly specific (192.168.34.1
). Why is that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that 33 is the default. I could be wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
33 definitely used to be/possibly is still the default. Doing a quick Google search returns tons of documents with 192.168.33.1
.
@bluebaroncanada unfortunately I'm still getting the error:
|
So weird. Are you on Mac or Linux by chance and you don't have |
@bshaffer did you check the permissions on your |
No description provided.