Curl Resource Request Test by marovelo · Pull Request #28 · bshaffer/oauth2-demo-php · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Curl Resource Request Test #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

marovelo
Copy link

@marovelo marovelo commented Nov 8, 2013

This Pull request is related to bshaffer/oauth2-server-php#254

@bshaffer
Copy link
Owner

bshaffer commented Nov 8, 2013

Can you please explain to me the reason for this pull request?

The "required scope" should be built into the resource action itself, ie hard coded somewhere, and not part of the request, as is the case in this PR.

@marovelo
Copy link
Author

This pull request is related to bshaffer/oauth2-server-php#254
Just to show my problem in code that I describe in this issue. However, as I said in the issue, the Test in this pull request doesn't fail.

@bshaffer
Copy link
Owner

Thank you for this. I am closing this since a test suite for this demo app will require a more standard method of testing (using behat/mink, etc).

However, I think the tests you've written would be a great addition to your own app imlementation

@bshaffer bshaffer closed this Nov 11, 2013
@bshaffer bshaffer reopened this Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.