Don't drop retry/refresh events before uiReceiver is set #754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because uiReceiver is set asynchronously it's possible to race with a call to retry or refresh on the PagingDataPresenter. Changed the implementation to record calling these methods and then forward the event when the uiReceiver is set. Test: ./gradlew test connectedCheck Fixes: b/330725007
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Because uiReceiver is set asynchronously it's possible to race with a call to retry or refresh on the PagingDataPresenter.
Changed the implementation to record calling these methods and then forward the event when the uiReceiver is set.
Testing
Test: ./gradlew test connectedCheck
Issues Fixed
Fixes: b/330725007