3.x: Fix ReplaySubject termination-subscription race emitting wrongly #7879
+171
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #7879 +/- ##
============================================
+ Coverage 99.62% 99.63% +0.01%
- Complexity 6801 6803 +2
============================================
Files 752 752
Lines 47707 47716 +9
Branches 6401 6400 -1
============================================
+ Hits 47527 47542 +15
+ Misses 84 77 -7
- Partials 96 97 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the subject's termination was racing with an incoming observer, there was a window when the buffer contained the terminal
NotificationLiteobject butdonewas still false, causing the leak of saidNotificationLiteobject as anonNextsignal.ReplayProcessoris not affected.The fix is to simply check if the next buffered item is a terminal signal and act accordingly. There is no need for a
doneindicator.The bug affects the unbounded, size- and time-bounded variants as well. The mistake was introduced almost 10 years ago in the very early days.
Tests were added to verify the correct behavior for
ReplaySubjectandReplayProcessor.ℹ️ There were small updates to 3
Amboperator tests because the new Eclipse 2025.06 was showing compiler error due to type-inference issues on them. Javac never complained so this could be one of those Eclipse weirdnesses that creep up sometimes. Now Eclipse is happy.Resolves #7878