-
Notifications
You must be signed in to change notification settings - Fork 6.6k
feat: veo samples for advanced control features #13485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: veo samples for advanced control features #13485
Conversation
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @katiemn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a set of new code samples for the veo-2.0-generate-001
model, expanding the demonstration of its advanced video generation capabilities. These samples cover scenarios such as controlling video generation with specific first and last frames, generating videos from existing video inputs, and applying fine-grained controls like disabling prompt rewriting and managing person generation within the output. The changes also include the necessary test coverage for these new examples.
Highlights
- New Video Generation Samples: I've added three new Python code samples demonstrating advanced control features for video generation using the
veo-2.0-generate-001
model. - First and Last Frame Control: One sample (
videogen_with_first_last_frame.py
) illustrates how to generate a video by providing both an initial image and a desired last frame, guiding the video's progression. - Video-to-Video Generation: Another sample (
videogen_with_vid.py
) showcases the ability to generate a new video based on an existing video input, allowing for transformations or continuations. - Fine-grained Generation Control: A third sample (
videogen_with_no_rewrite.py
) demonstrates how to disable prompt enhancement (enhance_prompt=False
) and control person generation (person_generation='dont_allow'
) for more precise output. - Automated Testing: Corresponding test cases have been added to
test_video_generation_examples.py
to ensure the functionality of these new video generation samples.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new code samples for VEO advanced control features, along with corresponding tests. The new samples demonstrate generating video from first/last frames, from another video, and with prompt rewriting disabled. My review identifies a correctness issue where the samples could crash, and several issues to improve test quality and naming consistency. Addressing these will significantly improve the robustness and maintainability of the new samples.
Description
Add new genai code samples for veo 2 advanced control features