-
Notifications
You must be signed in to change notification settings - Fork 40
Update OpenTelemetry dependencies #413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit b7c0dc1)
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
It seems like you need to run ./gradlew spotlessApply
to fix some style checks.
...esourcemapping/src/main/java/com/google/cloud/opentelemetry/resource/ResourceTranslator.java
Outdated
Show resolved
Hide resolved
...rcemapping/src/test/java/com/google/cloud/opentelemetry/resource/ResourceTranslatorTest.java
Outdated
Show resolved
Hide resolved
Thanks @psx95, styling and imports should now be ok! |
/gcbrun |
Hi @tschut, the CLA check is failing in the recent commits. Could you fix that ? I think it might be because you added commits that were created using a different email account not covered by the CLA. |
Crap. Rewrote a bit of history and I think it's correct now. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
This fixes #399