Change the suggested format token style #913
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [research](rubocop/rubocop#8827 (comment)): annotated (`%<name>s`): 57497 files inspected, 5785 offenses detected template (`%{name}`): 57497 files inspected, 1279 offenses detected unannotated (`%s`) 57497 files inspected, 6424 offenses detected the `%{name}` is the most commonly used style.
|
I'm OK with updating this rule, but I'd rather suggest to change the language to something suggesting that both the name and annotated styles are fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to research:
annotated (
%<name>s):57497 files inspected, 5785 offenses detected
template (
%{name}):57497 files inspected, 1279 offenses detected
unannotated (
%s)57497 files inspected, 6424 offenses detected
the
%{name}is the most commonly used style.Related:
Style/FormatStringTokenrubocop#8827templateinternally rubocop#11349