Ruby/QL: add discard predicates for locations by nickrolfe · Pull Request #19963 · github/codeql · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Ruby/QL: add discard predicates for locations #19963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ruby/QL: add discard predicates for locations #19963

wants to merge 1 commit into from
+118 −3

Conversation

nickrolfe
Copy link
Contributor

@nickrolfe nickrolfe commented Jul 3, 2025 •
edited
Loading

Since the tree-sitter-based extractors use * IDs for locations, they are not shared between a base database and an overlay, so we need to add discard_entity predicates to discard locations from the base in files that got re-extracted in the overlay.

@nickrolfe nickrolfe added the no-change-note-required This PR does not need a change note label Jul 3, 2025
@nickrolfe nickrolfe force-pushed the nickrolfe/overlay-deleted-files branch from b6d49dc to 2ac7bf8 Compare July 3, 2025 11:32
@nickrolfe nickrolfe force-pushed the nickrolfe/rb-discard-locations branch from cacc1c9 to 3a0c7bc Compare July 3, 2025 11:34
@nickrolfe nickrolfe force-pushed the nickrolfe/overlay-deleted-files branch from 2ac7bf8 to d8574a6 Compare July 3, 2025 11:44
@nickrolfe nickrolfe force-pushed the nickrolfe/rb-discard-locations branch from 3a0c7bc to 281d5cd Compare July 3, 2025 11:52
Base automatically changed from nickrolfe/overlay-deleted-files to main July 4, 2025 15:10
@nickrolfe nickrolfe force-pushed the nickrolfe/rb-discard-locations branch from 281d5cd to 7c5b186 Compare July 4, 2025 15:15
@nickrolfe nickrolfe marked this pull request as ready for review July 4, 2025 15:17
@Copilot Copilot AI review requested due to automatic review settings July 4, 2025 15:17
@nickrolfe nickrolfe requested review from a team as code owners July 4, 2025 15:17
github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 4, 2025
View reviewed changes
Copilot
Copilot AI reviewed Jul 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
no-change-note-required This PR does not need a change note QL-for-QL Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickrolfe

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.