Split out core functionality into separate module · Issue #1664 · uBlockOrigin/uBlock-issues · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Split out core functionality into separate module #1664

Closed
@mjethani

Description

@mjethani

Prerequisites

I tried to reproduce the issue when...

  • uBO is the only extension
  • uBO with default lists/settings
  • using a new, unmodified browser profile

Description

I have just updated the Cliqz benchmarks with the latest versions of Adblock Plus (ghostery/adblocker@a2da894) and Brave (ghostery/adblocker@97dc7c1)

Unfortunately it's not trivial to do the same for uBlock Origin, because of the relative tight coupling in the code. In fact, it keeps getting harder. For example, uritools.js now refers to the vAPI object whereas previously it did not.

It would be ideal if the core filter parsing, matching, and serialization functionality were split out into a separate Node.js module.

A specific URL where the issue occurs

N/A

Steps to Reproduce

Try to update the benchmarks at https://github.com/cliqz-oss/adblocker/tree/master/packages/adblocker-benchmarks with the latest version of uBlock Origin.

Expected behavior

It should be as easy as updating a version number or a commit hash in the package.json file in that repo.

Actual behavior

It's too much work that involves copying and modifying a bunch of files from the uBlock Origin repo.

uBlock Origin version

1.36.2

Browser name and version

N/A

Operating System and version

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestfixedissue has been addressed

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      TMZ Celebrity News – Breaking Stories, Videos & Gossip

      Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

      Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

      🎥 Watch TMZ Live

      TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.