Open
Description
Currently Tools/patchcheck/reindent.py1 replaces all tabs with spaces. However, in Tools/c-analyzer/cpython._parser.py there are embedded tab-based tables. Up to now I've basically ignored CI failures (from make patchcheck) in _parser.py, but I'd rather reindent.py be a little smarter (even if just a whitelist). 2 Tools/scripts/untabify.py sounds like it may have a similar story.
Linked PRs
- gh-92266: Replace tabs with four spaces in Python files #135983
- gh-92266: reindent.py: Add allowlist for files with tabs #135984
- [3.14] gh-92266: Replace tabs with four spaces in Python files (GH-135983) #136035
- [3.13] gh-92266: Replace tabs with four spaces in Python files (GH-135983) #136036
Footnotes
-
reindent.check()is used by Tools/patchcheck/patchcheck.py (AKAmake patchcheck). ↩ -
Addressing trailing-tabs-in-str-literals is even more relevant since I enabled the check-c-globals CI check. For example, see https://github.com/python/cpython/pull/102735#issuecomment-1470516458. ↩