Fix: Complete futures on shutdown by acocuzzo · Pull Request #746 · googleapis/python-pubsub · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Fix: Complete futures on shutdown #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Fix: Complete futures on shutdown #746

wants to merge 7 commits into from

Conversation

acocuzzo
Copy link
Contributor

@acocuzzo acocuzzo commented Jul 26, 2022 •
edited
Loading

Set "shutdown_mode" in the dispatcher. During this mode, set_exception(AcknowledgeError.OTHER) on dispatched callbacks.
When unary acks, modack, and nacks are returned check they are not already completed.

Fixes #747🦕

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: pubsub Issues related to the googleapis/python-pubsub API. labels Jul 26, 2022
@acocuzzo acocuzzo changed the title Complete futures on shutdown Fix: Complete futures on shutdown Jul 26, 2022
@acocuzzo acocuzzo mentioned this pull request Jul 26, 2022
Merged
4 tasks
@mukund-ananthu mukund-ananthu added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedroserrudo pedroserrudo pedroserrudo approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/python-pubsub API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete futures on irregular stream shutdown
3 participants
@acocuzzo @pedroserrudo @mukund-ananthu

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.