fix(observability): fix the spans for the abort transaction #2188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
surbhigarg92
force-pushed
the
abort_test
branch
from
6fc0c60 to
6a8a8a0
Compare
product-auto-label
bot
added
size: l
surbhigarg92
force-pushed
the
abort_test
branch
from
17f2aa9 to
430a33c
Compare
surbhigarg92
force-pushed
the
abort_test
branch
from
9245c37 to
f5d21a3
Compare
surbhigarg92
changed the title
| this.pool_.release(session!); | ||
| span.end(); | ||
| callback!(err); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| span.addEvent('Using Session', {'session.id': session?.id}); |
There was a problem hiding this comment.
nit: can we create a const file and put all these event names
sakthivelmanii
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes spans for the
runTransactionfor error cases and removes theDatabase.runspan.