feat: use specific W3CTraceContextPropagator for OTel #2036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaces the use of the global OpenTelemetry propagator (`propagation`) with a specific instance of `W3CTraceContextPropagator` within the `telemetry-tracing.ts` module. This ensures that trace context propagation for Pub/Sub messages always uses the W3C format via the `googclient_traceparent` attribute, regardless of the global propagator configured by your code. This is important for maintaining consistent tracing behavior, especially when context is passed through non-HTTP transports used by the library. The change involves: - Importing `W3CTraceContextPropagator` from `@opentelemetry/core`. - Instantiating the propagator. - Updating `injectSpan` and `extractSpan` to use the specific instance. Existing tests pass without modification as they implicitly relied on the W3C propagator behavior via the test setup's `BasicTracerProvider`.
product-auto-label
bot
added
size: s
hongalex
approved these changes
May 6, 2025
feywind
added
owlbot:ignore
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the use of the global OpenTelemetry propagator (
propagation) with a specific instance ofW3CTraceContextPropagatorwithin thetelemetry-tracing.tsmodule.This ensures that trace context propagation for Pub/Sub messages always uses the W3C format via the
googclient_traceparentattribute, regardless of the global propagator configured by user code. This maintains consistent tracing behaviour as it moves between library instances as a Pub/Sub attribute.Fixes #2005 🦕