fix: set messaging.operation in createAttributes by amychisholm03 · Pull Request #2030 · googleapis/nodejs-pubsub · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

fix: set messaging.operation in createAttributes #2030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 9, 2025
Merged

fix: set messaging.operation in createAttributes #2030

merged 7 commits into from
May 9, 2025

Conversation

amychisholm03
Copy link
Contributor

This is an amendment to PR #2019 which resolved issue #2018. I did not add the messaging.operation attribute to the correct place in the code; it is now set in a more logical spot: createAttributes. I also modified the tests to reflect this change.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Apr 23, 2025
@amychisholm03 amychisholm03 marked this pull request as ready for review April 23, 2025 18:57
@amychisholm03 amychisholm03 requested review from a team as code owners April 23, 2025 18:57
@feywind feywind changed the title fix: Set messaging.operation in createAttributes fix: set messaging.operation in createAttributes May 8, 2025
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 8, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 8, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 8, 2025
@feywind feywind added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 9, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 9, 2025
@feywind feywind merged commit b8d513a into googleapis:main May 9, 2025
14 of 15 checks passed
@release-please release-please bot mentioned this pull request May 8, 2025
Merged
@amychisholm03 amychisholm03 deleted the otel-sem-convs-addendum branch May 12, 2025 14:43
@bizob2828 bizob2828 mentioned this pull request Jun 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hongalex hongalex hongalex approved these changes

@feywind feywind feywind approved these changes

Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update native OTel to semantic conventions 1.24.0
4 participants
@amychisholm03 @hongalex @feywind @yoshi-kokoro

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.