fix clirr

rahul2393 · rahul2393 · commit 1b80ffe4e442 · 2025-05-08T15:49:52.000+05:30
diff --git a/google-cloud-spanner/clirr-ignored-differences.xml b/google-cloud-spanner/clirr-ignored-differences.xml
@@ -349,20 +349,6 @@
     <method>com.google.cloud.spanner.spi.v1.SpannerRpc$StreamingCall executeQuery(com.google.spanner.v1.ExecuteSqlRequest, com.google.cloud.spanner.spi.v1.SpannerRpc$ResultStreamConsumer, java.util.Map)</method>
     <to>com.google.cloud.spanner.spi.v1.SpannerRpc$StreamingCall executeQuery(com.google.spanner.v1.ExecuteSqlRequest, java.util.Map, boolean)</to>
   </difference>
-  <!-- (CompositeTracer is an internal API) -->
-  <difference>
-    <differenceType>7005</differenceType>
-    <className>com/google/cloud/spanner/CompositeTracer$CompositeTracer</className>
-    <method>void recordGFELatency(java.lang.Long)</method>
-    <to>void recordGFELatency(java.lang.Float)</to>
-  </difference>
-  <!-- (CompositeTracer is an internal API) -->
-  <difference>
-    <differenceType>7005</differenceType>
-    <className>com/google/cloud/spanner/CompositeTracer$CompositeTracer</className>
-    <method>void recordAFELatency(java.lang.Long)</method>
-    <to>void recordAFELatency(java.lang.Float)</to>
-  </difference>
   <difference>
     <differenceType>7006</differenceType>
     <className>com/google/cloud/spanner/spi/v1/GapicSpannerRpc</className>
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/CompositeTracer.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/CompositeTracer.java
@@ -191,10 +191,11 @@ public void addAttributes(Map<String, String> attributes) {
     }
   }
 
-  public void recordGFELatency(Float gfeLatency) {
+  @Deprecated
+  public void recordGFELatency(Long gfeLatency) {
     for (ApiTracer child : children) {
       if (child instanceof BuiltInMetricsTracer) {
-        ((BuiltInMetricsTracer) child).recordGFELatency(gfeLatency);
+        ((BuiltInMetricsTracer) child).recordGFELatency(Float.valueOf(gfeLatency));
       }
     }
   }
@@ -207,10 +208,11 @@ public void recordGfeHeaderMissingCount(Long value) {
     }
   }
 
-  public void recordAFELatency(Float afeLatency) {
+  @Deprecated
+  public void recordAFELatency(Long afeLatency) {
     for (ApiTracer child : children) {
       if (child instanceof BuiltInMetricsTracer) {
-        ((BuiltInMetricsTracer) child).recordAFELatency(afeLatency);
+        ((BuiltInMetricsTracer) child).recordAFELatency(Float.valueOf(afeLatency));
       }
     }
   }
@@ -222,4 +224,20 @@ public void recordAfeHeaderMissingCount(Long value) {
       }
     }
   }
+
+  public void recordGFELatency(Float gfeLatency) {
+    for (ApiTracer child : children) {
+      if (child instanceof BuiltInMetricsTracer) {
+        ((BuiltInMetricsTracer) child).recordGFELatency(gfeLatency);
+      }
+    }
+  }
+
+  public void recordAFELatency(Float afeLatency) {
+    for (ApiTracer child : children) {
+      if (child instanceof BuiltInMetricsTracer) {
+        ((BuiltInMetricsTracer) child).recordAFELatency(afeLatency);
+      }
+    }
+  }
 }

Original file line number	Diff line number	Diff line change
`@@ -191,10 +191,11 @@ public void addAttributes(Map<String, String> attributes) {`
`191`	`191`	`}`
`192`	`192`	`}`
`193`	`193`
`194`		`- public void recordGFELatency(Float gfeLatency) {`
	`194`	`+ @Deprecated`
	`195`	`+ public void recordGFELatency(Long gfeLatency) {`
`195`	`196`	`for (ApiTracer child : children) {`
`196`	`197`	`if (child instanceof BuiltInMetricsTracer) {`
`197`		`- ((BuiltInMetricsTracer) child).recordGFELatency(gfeLatency);`
	`198`	`+ ((BuiltInMetricsTracer) child).recordGFELatency(Float.valueOf(gfeLatency));`
`198`	`199`	`}`
`199`	`200`	`}`
`200`	`201`	`}`
`@@ -207,10 +208,11 @@ public void recordGfeHeaderMissingCount(Long value) {`
`207`	`208`	`}`
`208`	`209`	`}`
`209`	`210`
`210`		`- public void recordAFELatency(Float afeLatency) {`
	`211`	`+ @Deprecated`
	`212`	`+ public void recordAFELatency(Long afeLatency) {`
`211`	`213`	`for (ApiTracer child : children) {`
`212`	`214`	`if (child instanceof BuiltInMetricsTracer) {`
`213`		`- ((BuiltInMetricsTracer) child).recordAFELatency(afeLatency);`
	`215`	`+ ((BuiltInMetricsTracer) child).recordAFELatency(Float.valueOf(afeLatency));`
`214`	`216`	`}`
`215`	`217`	`}`
`216`	`218`	`}`
`@@ -222,4 +224,20 @@ public void recordAfeHeaderMissingCount(Long value) {`
`222`	`224`	`}`
`223`	`225`	`}`
`224`	`226`	`}`
	`227`	`+`
	`228`	`+ public void recordGFELatency(Float gfeLatency) {`
	`229`	`+ for (ApiTracer child : children) {`
	`230`	`+ if (child instanceof BuiltInMetricsTracer) {`
	`231`	`+ ((BuiltInMetricsTracer) child).recordGFELatency(gfeLatency);`
	`232`	`+ }`
	`233`	`+ }`
	`234`	`+ }`
	`235`	`+`
	`236`	`+ public void recordAFELatency(Float afeLatency) {`
	`237`	`+ for (ApiTracer child : children) {`
	`238`	`+ if (child instanceof BuiltInMetricsTracer) {`
	`239`	`+ ((BuiltInMetricsTracer) child).recordAFELatency(afeLatency);`
	`240`	`+ }`
	`241`	`+ }`
	`242`	`+ }`
`225`	`243`	`}`