impl(storage): serialize Object for uploads
#2585
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When inserting new objects the metadata can be included in the intial POST request (for resumable uploads), or in the first MIME-multipart section (for multipart uploads). Only a subset of the fields may be included in this initial upload, and some fields require transformations from the gRPC to the JSON data models. This change introduces the function to serialize via a `serde_json::Value`. We may optimize this further in a future set of changes.
product-auto-label
bot
added
the
api: storage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2585 +/- ##
==========================================
+ Coverage 95.28% 95.35% +0.06%
==========================================
Files 82 82
Lines 3375 3425 +50
==========================================
+ Hits 3216 3266 +50
Misses 159 159 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Jul 4, 2025
| @@ -244,9 +244,114 @@ impl From<Object> for control::model::Object { | |||
| } | |||
| } | |||
|
|
|||
| /// Create a JSON object for the [control::model::Object] fields used in uploads. | |||
| /// | |||
| /// When uploading (aka inserting) an object number of metadata fields can be | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inserting new objects the metadata can be included in the intial
POST request (for resumable uploads), or in the first MIME-multipart
section (for multipart uploads).
Only a subset of the fields may be included in this initial upload, and
some fields require transformations from the gRPC to the JSON data
models.
This change introduces the function to serialize via a
serde_json::Value. We may optimize this further in a future set ofchanges.
Part of the work for #2043