-
Notifications
You must be signed in to change notification settings - Fork 412
feat: Implement a Bigtable Emulator (WIP) #15247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
marete
wants to merge
204
commits into
googleapis:main
Choose a base branch
from
Unoperate:for_google
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logic from Table::MutateRow() will be moved here and this commit proposes the general structure of this class, for early review.
And unconditionally return an error status for the aggregation mutations, which we don't currently support.
Currently in use only for SetCell.
…ion. - Introduces a RowTransaction class to proxy mutations and record undo logs in case we needs to rewind. - Re-implements the SetCell mutation in the RowTransaction class. - Introduces all Undo types/actions for SetCell and records them in an undo stack. - For SetCell only and to facilitate testing with only SetCell mutations, introduces the use of RowTransaction in doing the mutation. - clang-format is run on all affected files (which has removed some headers, e.t.c. A test for SetCell is coming up and is not currently included here.
Populate a schema protobuf with the minimal fields and call Table::Create();
…utation. There is a crash later on, in the code that sets up the undo log, that will be fixed in an upcoming commit.
* emulator: mechanical formatting fixes by ci tool. * emulator: make clang-tidy happy.
* emulator: trivial: fix typo in rollback_test.cc * emulator: mechanical formatting fixes.
… they revealed in the code.
…e. (#20) It now has tests well beyond the initial rollback tests, dealing with all manner of bigtable mutations, so call it mutations_test.cc.
This implements the AddToCell mutation. * Unit tested and tests passing * Supports atomic rollback * Support Sum, Min and Max aggregations for non-negative Int64 numbers * It is now possible to create an aggregate column family (supporting AddToCell or MergeToCell)
…ixes' into fix_colmnrange_filter
We need it for tests of filters and ReadRow that do not have to or cannot start up the GRPC network server infrastructure.
…family. - There is a passing unit test that tests for this (which is fixed and shows up in this diff). - The CI test (bigtable_filters_integration_test) which revealed this bug now passes.
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is