feat(storage): Handle large read ranges in bidi read. #15152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
devbww
reviewed
May 20, 2025
| @@ -77,7 +79,9 @@ class ObjectDescriptorImpl | |||
| return CopyActiveRanges(std::unique_lock<std::mutex>(mu_)); | |||
| } | |||
|
|
|||
| auto CurrentStream(std::unique_lock<std::mutex>) const { return stream_; } | |||
| auto CurrentStream(std::unique_lock<std::mutex>) const { | |||
| return streams_[active_stream_]; | |||
There was a problem hiding this comment.
It looks like this is always streams_.back(), and therefore that active_stream_ is redundant.
| @@ -105,6 +109,8 @@ class ObjectDescriptorImpl | |||
|
|
|||
| std::unordered_map<std::int64_t, std::shared_ptr<ReadRange>> active_ranges_; | |||
| Options options_; | |||
| std::vector<std::shared_ptr<OpenStream>> streams_ = {}; | |||
There was a problem hiding this comment.
Is stream_ (line 104) dead now?
There was a problem hiding this comment.
Yeah, it is. Removed it now.
| @@ -200,7 +224,7 @@ void ObjectDescriptorImpl::Resume(google::rpc::Status const& proto_status) { | |||
| void ObjectDescriptorImpl::OnResume(StatusOr<OpenStreamResult> result) { | |||
| if (!result) return OnFinish(std::move(result).status()); | |||
| std::unique_lock<std::mutex> lk(mu_); | |||
| stream_ = std::move(result->stream); | |||
| streams_[0] = std::move(result->stream); | |||
There was a problem hiding this comment.
I know nothing about this code, but it looks a little weird that this isn't assigning the "active stream".
There was a problem hiding this comment.
Thanks for reviewing the PR @devbww
I was trying this code as a POC and yes you're right, I should update the active_stream_ here.
This is still WIP.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is