Have test_installation test that operations produce no warnings

EliahKagan · EliahKagan · commit a2ba4804a654 · 2025-06-15T19:14:43.000-04:00
By setting the `PYTHONWARNINGS` environment variable to `error` in
each of the subprocess invocations.

This is strictly stronger than passing `-Werror` for the `python`
commands, because it automatically applies to subprocesses (unless
they are created with a sanitized environment or otherwise with one
in which `PYTHONWARNINGS` has been customized), and because it
works for `pip` automatically.

Importantly, this will cause warnings internal to Python
subprocesses created by `pip` to be treated as errors. It should
thus surface any warnings coming from the `setuptools` backend.
diff --git a/test/test_installation.py b/test/test_installation.py
@@ -64,6 +64,7 @@ def _set_up_venv(rw_dir):
             subprocess.run,
             stdout=subprocess.PIPE,
             cwd=venv.sources,
+            env={**os.environ, "PYTHONWARNINGS": "error"},
         )
 
         return venv, run

Original file line number	Diff line number	Diff line change
`@@ -64,6 +64,7 @@ def _set_up_venv(rw_dir):`
`64`	`64`	`subprocess.run,`
`65`	`65`	`stdout=subprocess.PIPE,`
`66`	`66`	`cwd=venv.sources,`
	`67`	`+ env={**os.environ, "PYTHONWARNINGS": "error"},`
`67`	`68`	`)`
`68`	`69`
`69`	`70`	`return venv, run`