Tool tests could be a bit more strict in their assertions · Issue #83 · github/github-mcp-server · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Tool tests could be a bit more strict in their assertions #83

New issue
New issue
Open
Open
Tool tests could be a bit more strict in their assertions#83
Labels
testing
@williammartin

Description

@williammartin
williammartin
opened on Apr 3, 2025

Description

On #82 (comment), I was surprised to see that my mistake did not result in a failing test. On closer inspection, it appears that there is no assertion that we call the API with the expected values, only stubbing a response value:

github-mcp-server/pkg/github/issues_test.go

Lines 419 to 422 in bb56733

mock.WithRequestMatchHandler(
mock.PostReposIssuesByOwnerByRepo,
mockResponse(t, http.StatusCreated, mockIssue),
),

We should maybe look to tighten these tests up a bit, it would be very easy to break the tool implementations without knowing.

Metadata

Metadata

Assignees

No one assigned

    Labels

    testing

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      TMZ Celebrity News – Breaking Stories, Videos & Gossip

      Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

      Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

      🎥 Watch TMZ Live

      TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.