fix(editor): persist text scale after mode guess by goodvibrations32 · Pull Request #8185 · doomemacs/doomemacs · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

fix(editor): persist text scale after mode guess #8185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix(editor): persist text scale after mode guess #8185

wants to merge 1 commit into from

Conversation

goodvibrations32
Copy link

@goodvibrations32 goodvibrations32 commented Nov 30, 2024 •
edited
Loading

When a buffer is in fundamental mode saving the buffer should not rescale the text to default size.

Fix: #7378

  • I searched the issue tracker and this hasn't been PRed before.
  • My changes are not on the do-not-PR list for this project.
  • My commits conform to Doom's git conventions.
  • Any relevant issues or PRs have been linked to.

@goodvibrations32 goodvibrations32 requested a review from a team as a code owner November 30, 2024 13:14
goodvibrations32
goodvibrations32 commented Nov 30, 2024
View reviewed changes
Copy link
Author

@goodvibrations32 goodvibrations32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any feedback is welcomed.

@hlissner hlissner added is:bug Something isn't working as intended module:core Relevant to Doom core was:moved Is, was, or will be addressed elsewhere labels Dec 1, 2024
@hlissner hlissner marked this pull request as draft December 1, 2024 16:17
@hlissner hlissner added this to the core v3.0 milestone Dec 1, 2024
@goodvibrations32 goodvibrations32 force-pushed the master branch 4 times, most recently from 60fe66d to fed5653 Compare December 6, 2024 11:40
@goodvibrations32 goodvibrations32 marked this pull request as ready for review December 6, 2024 11:46
@goodvibrations32
fix(:editor): persist text scale after mode guess
d3920cf 
When a buffer is in fundamental mode saving the buffer should not
rescale the text to default.

Fix: doomemacs#7378
@goodvibrations32 goodvibrations32 marked this pull request as draft February 26, 2025 06:38
@goodvibrations32
Copy link
Author

i convert this back to draft as it seems more urgent work is happening. if i should rebase on the latest commit e.g. df3d64a or later at the future to help you add this without too much hassle let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
is:bug Something isn't working as intended module:core Relevant to Doom core was:moved Is, was, or will be addressed elsewhere
Projects
None yet
Milestone
core v3.0
Development

Successfully merging this pull request may close these issues.

doom-guess-mode-h doesn't preserve text-scale
2 participants
@goodvibrations32 @hlissner

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.