refactor(devtools): Port devtools app to zoneless #62454
Draft
+136
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeanMeche
force-pushed
the
devtools/zoneless
branch
4 times, most recently
from
a02e51c to
477b201
Compare
JeanMeche
commented
Jul 3, 2025
| private _setTimeout: typeof setTimeout = setTimeout, | ||
| // Binding is necessary to ensure that `setTimeout` is called in the global context. | ||
| // an doesn't throw "Illegal invocation" error. | ||
| private _setTimeout: typeof setTimeout = setTimeout.bind(globalThis), |
There was a problem hiding this comment.
This is one noticable breakage.
One cannot store a global without binding it to the global context.
With zone.js we reached out to the patched version, so we didn't have an issue.
JeanMeche
force-pushed
the
devtools/zoneless
branch
2 times, most recently
from
5ca66e6 to
e69aa15
Compare
All components are now OnPush.
JeanMeche
force-pushed
the
devtools/zoneless
branch
from
e69aa15 to
aad84e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All components are now OnPush.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information