DevTools: Prevent audit of about:blank

patrickhulce · Commit Bot · commit a3b3d85785ae · 2017-07-11T22:38:14.000Z
BUG=731197 Change-Id: I60786047e77c9569a78abe78699e0010f3915688 Reviewed-on: https://chromium-review.googlesource.com/527430 Commit-Queue: Patrick Hulce <phulce@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#485717} Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src Cr-Mirrored-Commit: 897b0f0e6b6054f5cf2419bf8891477a8eac1b20
diff --git a/front_end/audits2/Audits2Panel.js b/front_end/audits2/Audits2Panel.js
@@ -108,10 +108,22 @@ Audits2.Audits2Panel = class extends UI.PanelWithSidebar {
     return Audits2.Audits2Panel.Presets.some(preset => preset.setting.get());
   }
 
+  /**
+   * @return {?string}
+   */
+  _unauditablePageMessage() {
+    var inspectedURL = SDK.targetManager.mainTarget().inspectedURL();
+    if (/^about:/.test(inspectedURL))
+      return Common.UIString('Cannot audit about:* pages. Navigate to a different page to start an audit.');
+
+    return null;
+  }
+
   _updateStartButtonEnabled() {
     var hasActiveServiceWorker = this._hasActiveServiceWorker();
     var hasAtLeastOneCategory = this._hasAtLeastOneCategory();
-    var isDisabled = hasActiveServiceWorker || !hasAtLeastOneCategory;
+    var unauditablePageMessage = this._unauditablePageMessage();
+    var isDisabled = hasActiveServiceWorker || !hasAtLeastOneCategory || !!unauditablePageMessage;
 
     if (this._dialogHelpText && hasActiveServiceWorker) {
       this._dialogHelpText.textContent = Common.UIString(
@@ -122,6 +134,9 @@ Audits2.Audits2Panel = class extends UI.PanelWithSidebar {
     if (this._dialogHelpText && !hasAtLeastOneCategory)
       this._dialogHelpText.textContent = Common.UIString('At least one category must be selected.');
 
+    if (this._dialogHelpText && unauditablePageMessage)
+      this._dialogHelpText.textContent = unauditablePageMessage;
+
     if (this._dialogHelpText)
       this._dialogHelpText.classList.toggle('hidden', !isDisabled);
 
