Rust: Update legacy MaD models 4 #19948
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r these last few cases).
geoffw0
added
no-change-note-required
|
I think it will be prudent to get the first two/three PRs merged before attempting to address the test failures here. |
|
The test failures look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final update of legacy MaD models to the new model format (continues from #19946 and should be independent of that).
There's a lot of guesswork involved in this last set of changes - i.e. cases where I couldn't find a real
getCanonicalPath. There should be tests for most of them though so we will find out if we're way off.